[MOD][UI] Rollover Ally Info v1.4.5

NT

did you try just adding a conditional comparing the active player's team and the hovered-over objects team and only displaying the gold if that is the case? 

Did you go and assume I know how to code mods all that well? 

well I'm a terrible mod coder I don't want to learn the entire code base and script languages are generally terribly coded... 

I just figured that was more of a logical, generic programmer step to take. I've looked at the mod's code as well in the past to do the same thing you're doing and that's what I figured would fix it and I looked around to see where that would be stored (AIBrain, iono?) but I couldn't figure out how to check the army's team and it would have required a few other modifications as well so I just shrugged it off. 

Took a quick look at how it works, and each AIBrain just creates a sync table every beat containing its own gold, which gets pushed to all user sync tables.  InternalGiveResources and TakeResource would have to be destructively overridden to do an 'if IsAlly(GetFocusArmy(), self:GetArmyIndex()) then' check when populating this table, so each player's sync table only has allied gold in it.

Seems really simple and straightforward, but I've never messed with GetFocusArmy(), because it's easy to use it to create desyncs.  However, anything with effects/graphics and sync tables should be safe, so I'll give it a shot - I just won't be able to desync-test it.

Oh, and this change will break Chirmaya's version of the UI mod, which does a math.floor on ArmyGold[unit:GetArmy()], which will return nil and cause the entire rollover to stop functioning.  It's trivial to fix the UI mod so that it checks for the availability of the gold display before trying to read it, though.

Edit: Very trivial - the gold display block just needs an if condition after 'gold = ', like so:

AIBrain.lua hook with the absolute sim-side fix

This will be in any further releases of the Uberfix that I do (test or otherwise), and anyone can feel free to include it in any sim-side mod they want - it will play nice with itself, no matter how many copies of it are running.  I figured out a simple way to do it non-destructively, too.   I left gold visibility for observers in.  It's easy to remove if there's popular demand, but I figure there are already a jillion ways to use an observer client to cheat, and this one is pretty dang minor.

This fix does NOT break Chirmaya's final version of the mod, and will simply display 0 for enemy demigod gold amounts.  The original rollover mod can easily be changed to display nothing if gold is zero, AND not display enemy gold in non-fixed sim games by substituting this block, starting at line 264 of \hook\lua\ui\game\HUD_rollover.lua:

with this:

Yeah - I completely realize that as well, which was why there really wasn't much of a push to get this new version in place.  But that said, there's nothing to keep me from having the original post nuked so that folks can't get at the file if they don't already have it.  At the very least, a new version will be good for anyone that still likes the functionality of the mod, but feels like they are cheating by being able to see enemy gold. 

I see you've posted quite a bit of code and from your comment in the other thread, it sounds like you came up with a way to solve the gold problem.  I'll review as soon as I get a chance and I really appreciate your looking into this again for us.  Thanks!!!

and side note - I have a solution for that in mind... just need to see if I can get a buy in from stardock.

New executable is uploaded.  Op is updated.

Not sure I can pull that off tonight, but I'll check with some folks over the next few days and get a test going for you.  Thanks.

Compiled aibrain.lua into an exe.  Do not download/install this unless you are assisting me with testing.  http://www.box.net/shared/a5u98mllxe

ok - I did get a test in.  Miriyaka - please download the mod I uploaded above and confirm that I have it coded the way you wanted it (just a copy and paste, but let's make sure).  I played a > 30 min game against in1 (both of us having the mod installed) with no desyncs and all was normal.  Check my work and let me know. 

Yep, that looks fine.  Thanks for testing it.
Welp, actually, it isn't in a hook folder.  So it wasn't being used at all.  Modified it so that it should be running now: link

Uh... :/ Well, Pacov, I can test it with you one more time, if you wish.

Don't feel like you have to play an actual game with it - it's something that runs every time gold is given, which happens within the first 0.1 seconds of the game.  A desync should be nearly instant if it's going to happen at all.

I'm probably being unnecessarily paranoid about this, but I haven't been testing my code thoroughly enough (and not at all in multiplayer), and I want to make sure I'm not creating more problems than I'm fixing.

Yes, yes, that's all perfectly understandable, and I don't think you are unnecessarily paranoid, either. It's always better to "overdo" such things, so to say. Anyway, I'm available after ~7 PM EST, so I trust Pacov will contact me if he needs help: 20 minutes of my time is no epic sacrifice for community's sake.

Thanks guys.  If all goes well, I'll release another RC of the Uberfix with this change, and a lot of other things.  For what it's worth, I had managed to somehow screw up Oculus' Brain Storm in the last release, and I found a few other fixes dating back to 1.02 that weren't actually implemented properly, and weren't working (like the IgnoreFacing flags on Sludge Slinger et al).

did you merge in the Ironwalker's change and stuff? I've looked around on the google.code website but it was such a terrible mess it chased me away 

OK - here is a link to an executable using the aibrain.lua.  Figured I'd just compile the code properly as I already had the create exe script built:  http://www.box.net/shared/t6szahf1kp.

Again, only download this if you are helping me with testing. 

Ok - Darkliath was kind enough to test with me.  We played about 2 minutes of a game and there was no desync. 

In addition, using the original rollover ally info mod, with your coding change in place, I was unable to see the enemies gold, so it clearly is suppressing information as expected.  I'd say this is good to be added to uber. 

Just a quick fyi - seems like quite a few people have started using this mod now.  >30 downloads in our small community.  Good stuff!

Whoops, I just found a bug with the code I added to prevent the display of enemy gold - namely that it errors out when an observer mouses over any demigod.

Replace line 265 in HUD_rollover with the following, which gives observers a pass:

To be clear, this should be replacing:

Sorry about that - it never occurred to me to test it in observer mode, and I only discovered this problem with GetFocusArmy/IsAlly a few days ago when working with Peppe on the Skirmish AI mod.

Updated and published version 1.4.5 based on your revision.